Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public getDeclaredMethods method to ReflectionUtils #22580

Closed
Tracked by #22560
philwebb opened this issue Mar 13, 2019 · 0 comments
Closed
Tracked by #22560

Add public getDeclaredMethods method to ReflectionUtils #22580

philwebb opened this issue Mar 13, 2019 · 0 comments
Assignees
@philwebb
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.2 M1

Comments

@philwebb
Copy link
Member

philwebb commented Mar 13, 2019 •
edited by sbrannen
Loading

Although we can't directly expose the raw array of declared methods that we cache, there is still some benefit in having a public method that exposes a cloned copy. Specifically allows us to save security checks and it reduces the number of Method instances created. It's also often faster than calling doWithLocalMethods and needing to create a callback.
@philwebb philwebb self-assigned this Mar 13, 2019
@philwebb philwebb mentioned this issue Mar 13, 2019
Closed
23 tasks
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 13, 2019
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Mar 13, 2019
snicoll pushed a commit to snicoll/spring-framework that referenced this issue Mar 13, 2019
@philwebb @snicoll
Add public variant getDeclaredMethods method
570b098 
Add a public variant of `getDeclaredMethods` that defensively copies the
cached methods array. This is often more faster and more convenient
for users than calling `doWithLocalMethods`. We still retain most of the
benefits of the cache, namely fewer security manager calls and not as
many `Method` instances being created.

Closes spring-projectsgh-22580
philwebb added a commit to philwebb/spring-framework that referenced this issue Mar 14, 2019
@philwebb
Add public variant getDeclaredMethods method
3fb5bff 
Add a public variant of `getDeclaredMethods` that defensively copies the
cached methods array. This is often more faster and more convenient
for users than calling `doWithLocalMethods`. We still retain most of the
benefits of the cache, namely fewer security manager calls and not as
many `Method` instances being created.

Closes spring-projectsgh-22580
@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 23, 2019
@jhoeller jhoeller added this to the 5.2 M1 milestone Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M1
Development

No branches or pull requests
4 participants
@sbrannen @philwebb @jhoeller @spring-projects-issues