Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MergedAnnotation.getTypeHierarchy method #22908

Closed
philwebb opened this issue May 6, 2019 · 0 comments
Closed

Add MergedAnnotation.getTypeHierarchy method #22908

philwebb opened this issue May 6, 2019 · 0 comments
Assignees
@philwebb
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement

Comments

@philwebb
Copy link
Member

philwebb commented May 6, 2019

Currently AnnotatedElementUtils has a private parentAndType method that we use in getAllAnnotationAttributes. We're going to need a similar method for #22884 so it makes sense to make this a first class citizen of MergedAnnotation. We can probably also then cache the result in the AnnotationTypeMapping class.
@philwebb philwebb self-assigned this May 6, 2019
@philwebb philwebb added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels May 6, 2019
philwebb added a commit to philwebb/spring-framework that referenced this issue May 6, 2019
@philwebb
Add MergedAnnotation.getTypeHierarchy method
969cc19 
Add a `getTypeHierarchy()` method to `MergedAnnotation` that can be used
to return the full type hierarchy information. This method is
specifically designed to be used in combination with
`MergedAnnotationPredicates.unique`.

This update also allows us to delete the `parentAndType` method
from `AnnotatedElementUtils`.

Closes spring-projectsgh-22908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philwebb