Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSocketRequester.ResponseSpec Kotlin extensions issue #23185

Closed
slawluc opened this issue Jun 24, 2019 · 1 comment
Closed

RSocketRequester.ResponseSpec Kotlin extensions issue #23185

slawluc opened this issue Jun 24, 2019 · 1 comment
Assignees
@sdeleuze
Labels
in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug
Milestone
5.2 RC1

Comments

@slawluc
Copy link
Contributor

slawluc commented Jun 24, 2019 •
edited
Loading

Affects: Spring Framework 5.2.0-M3

Really glad you're integrating Kotlin, Coroutines and RSocket into the messaging module @sdeleuze

I think inline reified generics are needed on these new methods.

  • data
  • retrieveFlow
  • retrieveFlux
  • retrieveAndAwait
  • retrieveMono

requester.route("myRoute").data("123").retrieveFlow<String>()
gives me the following error

Caused by: java.lang.IllegalArgumentException: No decoder for ? at o.s.m.r.RSocketStrategies.decoder(RSocketStrategies.java:85) at o.s.m.r.DefaultRSocketRequester$DefaultResponseSpec.retrieveFlux(DefaultRSocketRequester.java:366) at o.s.m.r.DefaultRSocketRequester$DefaultResponseSpec.retrieveFlux(DefaultRSocketRequester.java:339)
I have a patch to fix the code and test in gist.
I can submit as a pull request shortly
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 24, 2019
slawluc added a commit to slawluc/spring-framework that referenced this issue Jun 24, 2019
@slawluc
Extension functions need to use reified types to create
d94542a 
ParameterizedTypeReference

Closes spring-projectsgh-23185
@sdeleuze sdeleuze self-assigned this Jun 24, 2019
@sdeleuze sdeleuze added in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug labels Jun 24, 2019
@sdeleuze sdeleuze added this to the 5.2 RC1 milestone Jun 24, 2019
@sdeleuze sdeleuze removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 24, 2019
slawluc added a commit to slawluc/spring-framework that referenced this issue Jun 24, 2019
@slawluc
Extension functions need to use reified types to create
848bd8c 
ParameterizedTypeReference, unused import removed.

Closes spring-projectsgh-23185
@slawluc slawluc mentioned this issue Jun 24, 2019
Closed
@slawluc
Copy link
Contributor Author

slawluc commented Jun 24, 2019

Added a pull request 23189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug
Projects
None yet
Milestone
5.2 RC1
Development

Successfully merging a pull request may close this issue.

RSocketRequester.ResponseSpec Kotlin extensions issue slawluc/spring-framework
3 participants
@sdeleuze @slawluc @spring-projects-issues