Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-prefix comment support for @SqlConfig #23331

Closed
1 task done
sbrannen opened this issue Jul 22, 2019 · 1 comment
Closed
1 task done

Add multi-prefix comment support for @SqlConfig #23331

sbrannen opened this issue Jul 22, 2019 · 1 comment
Assignees
@sbrannen
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
5.2 RC1

Comments

@sbrannen
Copy link
Member

sbrannen commented Jul 22, 2019 •
edited
Loading

Overview

As a follow up to gh-23289, we should also support multiple single-line comment prefixes in @SqlConfig for the @Sql support in spring-test in order to stay true to the Javadoc for @Sql.

The configuration options provided by this annotation and @SqlConfig are equivalent to those supported by ScriptUtils and ResourceDatabasePopulator...

Deliverables

  • Introduce String[] commentPrefixes() default "" in @SqlConfig.
@sbrannen sbrannen added this to the 5.2 RC1 milestone Jul 22, 2019
@sbrannen sbrannen self-assigned this Jul 22, 2019
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Jul 22, 2019
@sbrannen sbrannen mentioned this issue Jul 22, 2019
Closed
@sbrannen
Copy link
Member Author

Current work on this issue can be viewed in the following feature branch.

https://github.com/sbrannen/spring-framework/commits/issues/gh-23331-multi-prefix-comments-in-sql-annotation

sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jul 24, 2019
@sbrannen
Add multi-prefix comment support for @SqlConfig
1a9d168 
spring-projectsgh-23289 introduced support for multiple single-line comment prefixes
for ScriptUtils, ResourceDatabasePopulator, and EmbeddedDatabaseBuilder.

This commit adds the same support for @SqlConfig in the TestContext
Framework. Specifically, @SqlConfig has a new `commentPrefixes`
attribute for setting multiple single-line comment prefixes.

Closes spring-projectsgh-23331
@sbrannen sbrannen changed the title Add multi-prefix comment support for @Sql Add multi-prefix comment support for @SqlConfig Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 RC1
Development

No branches or pull requests
1 participant
@sbrannen