Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache isFactoryBean detection #23337

Closed
philwebb opened this issue Jul 23, 2019 · 0 comments
Closed

Cache isFactoryBean detection #23337

philwebb opened this issue Jul 23, 2019 · 0 comments
Assignees
@philwebb
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.2 RC1

Comments

@philwebb
Copy link
Member

The AbstractBeanFacory.isFactoryBean method would benefit from caching the result of isFactoryBean since it's called at least once per-bean for each call to getBeanNamesForType.
@philwebb philwebb added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jul 23, 2019
@philwebb philwebb added this to the 5.2 RC1 milestone Jul 23, 2019
@philwebb philwebb self-assigned this Jul 23, 2019
@philwebb philwebb mentioned this issue Jul 23, 2019
Closed
6 tasks
philwebb added a commit to philwebb/spring-framework that referenced this issue Jul 23, 2019
@philwebb
Cache AbstractBeanFactory.isFactoryBean results
2699738 
Add an additional cache to the `RootBeanDefinition` to save
recalculating the result of `isFactoryBean`.

Closes spring-projectsgh-23337
@jhoeller jhoeller mentioned this issue Aug 3, 2023
Closed
This was referenced Feb 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 RC1
Development

No branches or pull requests
1 participant
@philwebb