Update Scheduled.java Javadoc to explicitly include cron element order #22777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly mention order of elements in a cron expression.
|
@ottlinger Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@ottlinger Thank you for signing the Contributor License Agreement! |
sbrannen
requested changes
Apr 9, 2019
spring-context/src/main/java/org/springframework/scheduling/annotation/Scheduled.java
Outdated
Show resolved
Hide resolved
sbrannen
removed
the
status: waiting-for-triage
Changed markup although javadoc will be generated correctly as requested.
sbrannen
approved these changes
Apr 9, 2019
|
This has been merged into Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stumbling upon
https://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/scheduling/annotation/Scheduled.html
I realised that the order is quite difficult to parse for the human eye.
Thus I shortened the initial/first sentence and added the explicit order of the elements for easier reference.