Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish CONTRIBUTING.md #22891

Closed
wants to merge 1 commit into from
Closed

Polish CONTRIBUTING.md #22891

wants to merge 1 commit into from

Conversation

rewolf
Copy link
Contributor

@rewolf rewolf commented May 5, 2019

Change "72 lines for the description" to " 72-character lines for the description"
Fixes #22890

@rewolf
Update CONTRIBUTING.md to insert missing word
0e63cce 
Change "72 lines for the description" to " 72-character lines for the description"
Fixes #22890
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 5, 2019
@rewolf
Copy link
Contributor Author

rewolf commented May 5, 2019

This is my first contribution. I also found some ambiguity in the documentation regarding contributing:
The CONTRIBUTING.md suggests to create a ticket in step 2 of "Submit a Pull Request", but when creating a pull request it says to do either one or the other. Hence I created a ticket first and then a PR to fix it. But I now see that I probably should just have done a PR as it creates an issue anyway.

Is there a better way to clarify the correct usage, I wonder?

@snicoll snicoll mentioned this pull request May 5, 2019
Closed
snicoll pushed a commit that referenced this pull request May 5, 2019
@rewolf @snicoll
Polish CONTRIBUTING.md
6eb4ac6 
See gh-22891
@snicoll snicoll closed this in 1542d97 May 5, 2019
snicoll added a commit that referenced this pull request May 5, 2019
@snicoll
Merge pull request #22891 from rewolf
7d0a494 
* pr/22891:
  Polish contribution
  Polish CONTRIBUTING.md
@snicoll
Copy link
Member

snicoll commented May 5, 2019

@rewolf thank you for making your first contribution to Spring Framework. You are correct that the page still refers to the process when we used Jira as the issue tracker. I've created #22892 to make sure we review it.

@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 5, 2019
@snicoll snicoll self-assigned this May 5, 2019
@snicoll snicoll added this to the 5.2 M2 milestone May 5, 2019
@snicoll snicoll changed the title Update CONTRIBUTING.md to insert missing word Polish CONTRIBUTING.md May 5, 2019
@rewolf rewolf deleted the patch-1 branch May 5, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: documentation A documentation task
Projects
None yet
Milestone
5.2 M2
Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.md missing word in commit message formatting description
3 participants
@rewolf @snicoll @spring-projects-issues