Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queryParams and replaceQueryParams with Collection to UriBuilder #23119

Closed
wants to merge 1 commit into from
Closed

Add queryParams and replaceQueryParams with Collection to UriBuilder #23119

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Jun 12, 2019 •
edited
Loading

Add UriBuilder.queryParams(name, Collection<?> values) and UriBuilder.replaceQueryParams(name, Collection<?> values) methods to provide multiValued query parameters.

gh-23114

@nosan
Add UriBuilder.queryParams(name, Collection<?> values) and
4e34a45 
UriBuilder.replaceQueryParams(name, Collection<?> values) methods
to provide `multiValued` query parameters.

spring-projectsgh-23114
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 12, 2019
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Jun 14, 2019
@rstoyanchev rstoyanchev added this to the 5.2 RC1 milestone Jun 17, 2019
@rstoyanchev rstoyanchev mentioned this pull request Jun 17, 2019
Closed
@rstoyanchev rstoyanchev changed the title Add UriBuilder.queryParams and UriBuilder.replaceQueryParams for the collection Add queryParams and replaceQueryParams with Collection to UriBuilder Jun 17, 2019
@rstoyanchev rstoyanchev self-assigned this Jun 17, 2019
@rstoyanchev rstoyanchev removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 19, 2019
@rstoyanchev
Copy link
Contributor

Thanks for the pull request. I've made a couple of adjustments.

  • dropped the "s" from the method names as they both deal with a single parameter.
  • switched the implementations around so that the new List variants delegate to the existing varag variant and not other way around, to avoid the extra List creation for all existing methods.

@nosan
Copy link
Contributor Author

nosan commented Jul 5, 2019

Thank you very much @rstoyanchev

@nosan nosan deleted the gh-23114 branch July 5, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev Awaiting requested review from rstoyanchev

Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@nosan @rstoyanchev @sbrannen @spring-projects-issues