Treat null path as non-matching pattern in AntPathMatcher #23297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: core
sbrannen
changed the title
sbrannen
removed
the
status: waiting-for-triage
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Jul 17, 2019
sbrannen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes gh-943.
I noticed that the MVC Test
redirectedUrlmatcher fails with aNullPointerExceptionif there happens to be no "Redirected URL" on the response (the test should still fail, but with a proper assertion error).One way to fix this would be to
assertNotNullin the respectiveMockMvcResultMatchersmethod before calling theAntPathMatcher, but I thought it would be more appropriate to fix the underlying null-safety issues. You may disagree.