-
Notifications
You must be signed in to change notification settings - Fork 38k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow UriTemplate to be built with an empty template #32432
Conversation
@bsgrd Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@bsgrd Thank you for signing the Contributor License Agreement! |
@bsgrd has this been tried with Spring Cloud Gateway already? If this change is definitely sufficient for the purposes there, that would be great to know. Also, do you happen to have any unit tests for the empty template case, e.g. for Last but not least, it would be great to rebase this PR onto our 6.1.x branch since that is were it would get merged first. |
Just added a few unit tests to It would be great to know whether this works with Spring Cloud Gateway, in any case. And it would help to have the PR rebased onto 6.1.x, we could merge it as-is for tomorrow's 6.1.5 release then. |
@jhoeller Thank you for your feedback. |
@bsgrd thanks that helps. As for the rebase, no worries, we'll handle that on our side. |
@bsgrd thanks very much for making your first contribution to Spring Framework. |
Fixes spring-cloud/spring-cloud-gateway#3201