Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EnhancedLogFactory #1054

Closed
wants to merge 2 commits into from
Closed

Add EnhancedLogFactory #1054

wants to merge 2 commits into from

Conversation

garyrussell
Copy link
Contributor

  • add Supplier<Object> log methods
  • add tracing to CloseSafeProducer

If you agree with the approach, I'll change all logging.

@garyrussell
Add EnhancedLogFactory
e27bb22 
- add `Supplier<Object>` log methods
- add tracing to `CloseSafeProducer`
artembilan
artembilan approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I had the same thought for our regular logger in Spring.
Glad you asked Juergen on the matter!

So, I don't have objections to go ahead with this. 😄

@garyrussell garyrussell changed the title Add EnhancedLogFactory [PoC DO NOT MERGE] Add EnhancedLogFactory Apr 1, 2019
@garyrussell
Copy link
Contributor Author

On hold - see spring-projects/spring-framework#22726

@garyrussell garyrussell closed this Apr 2, 2019
@garyrussell garyrussell self-assigned this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan approved these changes

Assignees

@garyrussell garyrussell

Labels
type: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyrussell @artembilan