Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose deployment #1651

Closed

Conversation

pankajpc15
Copy link

@pankajpc15 pankajpc15 commented Sep 6, 2024

Implement Docker Deployment with Docker Compose

Description:

This Pull Request introduces Docker deployment for our application using Docker Compose. The following changes have been made:

Added Docker Compose Configuration:

Created a docker-compose.yml file to define services, networks, and volumes for the application.
Configured services for the application, including any necessary environment variables and dependencies.
Updated Dockerfile:

Adjusted the Dockerfile to be compatible with the Docker Compose setup.
Tested Deployment:

Verified that the Docker Compose setup works correctly by running and testing the containers locally.

@pivotal-cla
Copy link

@pankajpc15 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@pankajpc15 Thank you for signing the Contributor License Agreement!

@pankajpc15
Copy link
Author

@pivotal-cla sign agreement successfully

@pankajpc15
Copy link
Author

updated with the naming convention

@pankajpc15
Copy link
Author

@pivotal-cla can you accept PR

@@ -0,0 +1,10 @@
FROM openjdk:17-jdk-slim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a never one like 21/22 jdk version?

Copy link
Author

@pankajpc15 pankajpc15 Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrzejsydor
Great observation! I chose JDK 17 because it's a long-term support release, ensuring stability and extended support. Additionally, the project code is fully compatible with Java 17, so I opted for it.

@dsyer
Copy link
Member

dsyer commented Sep 11, 2024

I don't think we can merge this because it removes the existing configuration with MySQL. I'm not sure why you would prefer to launch the app in a container with docker-compose when it is running locally, so probably this change is targeted at some platform? Anyway, the local integration tests and dev time application launch (from CLI or IDE) would break if we make these changes (see CI build failures below).

@dsyer dsyer closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants