-
Notifications
You must be signed in to change notification settings - Fork 23.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a Spring AI based chatbot in Petclinic #1656
Conversation
…ing the owners, also guides the user through adding a pet to an owner, but currently fails to call the addPetToOwner function.
…d docs. Overall cleanup.
This looks like really good work and sticks well (but maybe not quite well enough) to the constraints we impose on this project. The main constraint it violates is "no new features", so I'm not sure we want to merge really, but it's good to see how to do it. There's always the possibility of creating a new project in https://github.com/spring-petclinic. I'm quite pleased that the Javascript is nearly free of dependencies, but it would be better to use webjars (same as all the others). The CSS changes probably need to go in |
Perhaps it makes more sense to include this in a separate branch and not the main branch? |
A separate branch might be good. It would be unlikely to get any maintenance, but it's probably a good way to evolve the feature (which feels like it might need to mature a bit - e.g. making something that works without any additional configuration maybe, or without a subscription at least). |
I created a new branch |
Thanks, will do. I added documentation in the main |
Nice! I missed that somehow. |
This pull request adds a new Chatbot in Spring Petclinic.
It can be used used to ask the clinic questions about owners and vets.
Some of the questions you may ask:
And many more.
The implementation is under the spring profile
openai
, which is the only supported LLM at the moment (either azure-openai or regular openai). In the default profile, the chatbot returns "chat is unavailable".See guide in main
readme.md
on how to use.