SDK-2870: Use new structure of test data provider #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
============================================
+ Coverage 69.31% 69.33% +0.01%
- Complexity 2022 2024 +2
============================================
Files 147 147
Lines 5306 5306
============================================
+ Hits 3678 3679 +1
+ Misses 1628 1627 -1
|
DmytroKlymanSpryker
requested review from
VladislavStrelchenko and
pavelmaksimov25
pavelmaksimov25
approved these changes
Jul 6, 2023
| * | ||
| * @return string | ||
| */ | ||
| public function getProjectMockOriginalPath(): string |
There was a problem hiding this comment.
this method should be protected if it is not a test method or isn't a data provider.
There was a problem hiding this comment.
Yes, I missed that. I changed the visibility of the parent methods, it really has no sense to make them public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.