Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-2973: added integration branch name #127

Merged
merged 4 commits into from
Jul 24, 2023
Merged

SDK-2973: added integration branch name #127

merged 4 commits into from
Jul 24, 2023

Conversation

vol4onok
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Merging #127 (195bb24) into master (b5d1cae) will increase coverage by 11.04%.
The diff coverage is 93.33%.

@@              Coverage Diff              @@
##             master     #127       +/-   ##
=============================================
+ Coverage     69.62%   80.66%   +11.04%     
+ Complexity     2056     1585      -471     
=============================================
  Files           150      141        -9     
  Lines          5395     4262     -1133     
=============================================
- Hits           3756     3438      -318     
+ Misses         1639      824      -815
Impacted Files Coverage Δ
src/Console/DiffGenerateConsole.php 68.42% <85.71%> (+3.90%) ⬆️
src/Executor/ReleaseGroup/DiffGenerator.php 75.51% <100.00%> (+1.51%) ⬆️

... and 9 files with indirect coverage changes

pavelmaksimov25
pavelmaksimov25 reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@pavelmaksimov25 pavelmaksimov25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you let me know why the changes aren't covered with tests?

@pavelmaksimov25 pavelmaksimov25 added the QA Done QA or Dev QA is done. label Jul 24, 2023
@pavelmaksimov25 pavelmaksimov25 merged commit 715fc75 into master Jul 24, 2023
16 checks passed
@pavelmaksimov25 pavelmaksimov25 deleted the bugfix/sdk-2973-rating-calculation branch July 24, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelmaksimov25 pavelmaksimov25 pavelmaksimov25 approved these changes

@DmytroKlymanSpryker DmytroKlymanSpryker DmytroKlymanSpryker approved these changes

Assignees
No one assigned
Labels
QA Done QA or Dev QA is done.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vol4onok @pavelmaksimov25 @DmytroKlymanSpryker