HowTo guide - one worker for all stores and it's benefits #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishakuta
requested review from
VadymSachenko,
lenadoc,
AlexSlawinski and
andriitserkovnyi
as code owners
gechetspr
reviewed
Jul 17, 2023
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
…-execution-costs-without-refactoring.md
gechetspr
reviewed
Jul 20, 2023
There was a problem hiding this comment.
Please check my proposal for the code example.
Actual document is good, but would be nice to give a bit more context for the implementation. What I think would be nice is not to give direct example to copy paste (that diff is super useful already), but to describe what changes need to be implemented in order to make your solution work.
In any case - great work!
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
.../dev/tutorials-and-howtos/howtos/howto-reduce-jenkins-execution-costs-without-refactoring.md
Outdated
Show resolved
Hide resolved
gechetspr
previously approved these changes
Jul 21, 2023
|
Now it looks like I've added all the essential code snippets and also a description/explanation for those, as the PR has been approved by technical reviewer - I think it can be processed further. |
|
@ishakuta All good, no big changes from last time that I can see :) Approving. |
AlexSlawinski
previously approved these changes
Jul 25, 2023
AlexSlawinski
previously approved these changes
Jul 27, 2023
This reverts commit ce1be11.
AlexSlawinski
previously approved these changes
Jul 27, 2023
AlexSlawinski
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reduce Jenkins execution by up to 80% without P&S and Data importers refactoring
a guide on how to integrate custom one Worker for all stores to either save Jenkins-related resources or speedup background processing.
Checklist