Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Oryx design tokens #2025

Merged
merged 18 commits into from
Aug 17, 2023
Merged

docs: Oryx design tokens #2025

merged 18 commits into from
Aug 17, 2023

Conversation

tobi-or-not-tobi
Copy link
Contributor

@tobi-or-not-tobi tobi-or-not-tobi commented Jul 24, 2023

Documentation on design tokens in Oryx.

closes HRZ-2165

tolerants
tolerants previously approved these changes Jul 25, 2023
andriitserkovnyi and others added 3 commits August 2, 2023 10:39
Co-authored-by: jmartinspryker <128468908+jmartinspryker@users.noreply.github.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update this document in 202307.0 as well.

@@ -43,7 +43,7 @@ For more information about feature sets, see [Feature sets](/docs/scos/dev/front

## Themes

A *theme* represents the global visual appearance of an application, including typography, colors, and other specific design elements, such as the color of a form field's placeholder. Themes are built with design tokens, which are configurable values that are used in CSS properties. Configuring these design tokens lets you customize a theme and align the application and its components with your brand identity or specific design requirements.
A _theme_ represents the global visual appearance of an application, including typography, colors, and other specific design elements, such as the color of a form field's placeholder. Themes are built with [design tokens](/docs/scos/dev/front-end-development/{{page.version}}/oryx/styling/oryx-design-tokens.html), which are configurable values that are used in CSS properties. Configuring these design tokens lets you customize a theme and align the application and its components with your brand identity or specific design requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add these changes to 202307 please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you create a new document in 202212, not in 202307?
We need to have them in both versions, at least.

@andriitserkovnyi andriitserkovnyi requested a review from a team as a code owner August 10, 2023 09:30
VadymSachenko
VadymSachenko previously approved these changes Aug 16, 2023
@andriitserkovnyi andriitserkovnyi added the new PR contains a new document label Aug 16, 2023
@andriitserkovnyi andriitserkovnyi merged commit c805805 into master Aug 17, 2023
14 checks passed
@andriitserkovnyi andriitserkovnyi deleted the docs/HRZ-2165-design-tokens branch August 17, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new PR contains a new document
Development

Successfully merging this pull request may close these issues.

5 participants