Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle data with Publish and Synchronization #2052

Conversation

VadymSachenko
Copy link
Contributor

@VadymSachenko VadymSachenko commented Aug 1, 2023

PR Description

there was $messageId in the interface and $idMessage in the implementation and $messageId passed to the method call, which didn't work. Fixed code so as to have $idMessage as parameter

Original PR: #2041

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

hidranarias and others added 2 commits July 26, 2023 15:26
there was $messageId in the interface and $idMessage in the implementation and $messageId passed to the method call, which didn't work.
Fixed code so as to have $idMessage as parameter
@VadymSachenko VadymSachenko added ready for merge The PR can be merged small changes PR contains small changes, like typo fixes labels Aug 1, 2023
@VadymSachenko VadymSachenko changed the title Hidranarias data manipulation publish synchronize fix id message Handle data with Publish and Synchronization Aug 1, 2023
@VadymSachenko VadymSachenko merged commit 7f3ae09 into master Aug 2, 2023
14 checks passed
@VadymSachenko VadymSachenko deleted the hidranarias-data-manipulation-publish-synchronize-fix-idMessage branch August 2, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge The PR can be merged small changes PR contains small changes, like typo fixes
Development

Successfully merging this pull request may close these issues.

3 participants