Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Vertex #2085

Merged
merged 10 commits into from
Aug 14, 2023
Merged

Conversation

Maksym-Ohnianikov
Copy link
Contributor

@Maksym-Ohnianikov Maksym-Ohnianikov commented Aug 10, 2023

Task: https://spryker.atlassian.net/browse/PBC-2073

Change log:

  • Additional info added
  • Small fixes

matweew
matweew previously approved these changes Aug 10, 2023
@VadymSachenko VadymSachenko added the updated PR contains meaningful changes to some document label Aug 10, 2023
@VadymSachenko VadymSachenko changed the title PBC-2073: Additional info Install Vertex Aug 10, 2023

`Pyz/Zed/{YourDesiredModule}/Communication/Plugin/Quote/CalculableObjectCustomerWithVertexExemptionCertificateExpanderPlugin.php`

The following code sample shows how to introduce the following expander plugins:
Copy link
Contributor

@VadymSachenko VadymSachenko Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to mention the plugins above, then rephrase this sentence as follows. Also, "implement" looks more technically specific than "introduce".

Suggested change
The following code sample shows how to introduce the following expander plugins:
The following code sample shows how to implement the previously mentioned plugins:

VadymSachenko
VadymSachenko previously approved these changes Aug 10, 2023
@VadymSachenko VadymSachenko added the ready for merge The PR can be merged label Aug 10, 2023
@VadymSachenko VadymSachenko merged commit 56524e8 into master Aug 14, 2023
14 checks passed
@VadymSachenko VadymSachenko deleted the feature/pbc-2073/dev-tax-app-integration-guide branch August 14, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge The PR can be merged updated PR contains meaningful changes to some document
Development

Successfully merging this pull request may close these issues.

3 participants