Update CORS configurations #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $config[GlueApplicationConstants::GLUE_APPLICATION_DOMAIN] = 'https://glue.mysprykershop.com'; | ||
| $config[GlueApplicationConstants::GLUE_APPLICATION_CORS_ALLOW_ORIGIN] = 'https://glue.mysprykershop.com'; | ||
| $config[GlueApplicationConstants::GLUE_APPLICATION_REST_DEBUG] = false; | ||
| Add the necessary parameters to `deploy.yml`: |
There was a problem hiding this comment.
What are the necessary param?
| @@ -78,7 +99,22 @@ To make sure that the CORS headers are set up correctly, send the OPTIONS reques | |||
|
|
|||
| * Verify that the `access-control-allow-origin` header is present and is the same to the one set in `config`. | |||
There was a problem hiding this comment.
What's the config in this context?
| @@ -78,7 +99,22 @@ To make sure that the CORS headers are set up correctly, send the OPTIONS reques | |||
|
|
|||
| * Verify that the `access-control-allow-origin` header is present and is the same to the one set in `config`. | |||
| * Verify that the `access-control-allow-methods` header is present and contains all available methods. | |||
There was a problem hiding this comment.
How do we know which methods are available?
…' of https://github.com/spryker/spryker-docs into feature/sc-4807/define-cors-allow-origin-via-deploy-yml
andriitserkovnyi
added
new
andriitserkovnyi
deleted the
feature/sc-4807/define-cors-allow-origin-via-deploy-yml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Ticket - https://spryker.atlassian.net/browse/SC-4807
Checklist