Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRW-5799 Added Install the Data Exchange API + Inventory Management feature #2151

Merged
merged 8 commits into from
Oct 9, 2023
Merged

FRW-5799 Added Install the Data Exchange API + Inventory Management feature #2151

merged 8 commits into from
Oct 9, 2023

Conversation

dimitriyTsemma
Copy link
Contributor

@dimitriyTsemma dimitriyTsemma commented Sep 7, 2023 •
edited
Loading

PR Description

Ticket: https://spryker.atlassian.net/browse/FRW-5809

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@dimitriyTsemma dimitriyTsemma added tech review needed PR needs tech review in tech review PR is in review by a developer new PR contains a new document and removed tech review needed PR needs tech review labels Sep 7, 2023
asmarovydlo
asmarovydlo previously approved these changes Sep 11, 2023
View reviewed changes
@dimitriyTsemma dimitriyTsemma added TW review needed PR needs Technical writer's review and removed in tech review PR is in review by a developer labels Sep 11, 2023
@lenadoc lenadoc added in TW review PR is in review by a technical writer and removed TW review needed PR needs Technical writer's review labels Oct 5, 2023
lenadoc
lenadoc reviewed Oct 5, 2023
View reviewed changes
...07.0/glue-api/dynamic-data-api/install-the-data-exchange-api-inventory-management-feature.md Outdated

### Sending a `PATCH` request
This request needs to include the necessary headers, such as Content-Type, Accept, and Authorization, with the access token provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove some of the information and instead give reference to the howto guide? That is, I would suggest replacing lines 69-82 with the following text:
"Let's say you want to have a new endpoint /dynamic-data/stock-products to operate with data in spy_stock_product table in database. Send the PATCH request to update the product stock data according to the guidelines in [How to send a request in Data Exchange] API (/docs/scos/dev/glue-api-guides/202307.0/data-exchange-api/how-to-guides/how-to-send-request-in-data-exchange-api.html):"

What do you think?

Copy link
Contributor Author

@dimitriyTsemma dimitriyTsemma Oct 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have information about the stock-products endpoint in the How To guide, so it looks like we can't remove anything here (

@lenadoc lenadoc merged commit 41adc04 into master Oct 9, 2023
13 checks passed
@lenadoc lenadoc deleted the feature/frw-5799/master-sync-storefront-and-storefront-api branch October 9, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenadoc lenadoc lenadoc left review comments

@asmarovydlo asmarovydlo asmarovydlo left review comments

Assignees

@lenadoc lenadoc

Labels
in TW review PR is in review by a technical writer new PR contains a new document
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimitriyTsemma @asmarovydlo @lenadoc