Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRW-6331 Provided documentation for Complex endpoint method GET #2369

Merged
merged 7 commits into from
Jan 11, 2024
Merged

FRW-6331 Provided documentation for Complex endpoint method GET #2369

merged 7 commits into from
Jan 11, 2024

Conversation

dimitriyTsemma
Copy link
Contributor

@dimitriyTsemma dimitriyTsemma commented Dec 5, 2023 •
edited by asmarovydlo
Loading

PR Description

https://spryker.atlassian.net/browse/FRW-6341

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@dimitriyTsemma dimitriyTsemma added the in tech review PR is in review by a developer label Dec 5, 2023
@dimitriyTsemma dimitriyTsemma changed the title FRW-6331 Provided documentation for Complex endpoint FRW-6331 Provided documentation for Complex endpoint method GET Dec 5, 2023
@dimitriyTsemma dimitriyTsemma added the updated PR contains meaningful changes to some document label Dec 5, 2023
gechetspr
gechetspr requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@gechetspr gechetspr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also documentation MUST address when we want to get missing relations, when we have chain of relations and if we fetch all data for relation or with some limitations.

_includes/pbc/all/install-features/202311.0/install-the-data-exchange-api.md Outdated Show resolved Hide resolved
_includes/pbc/all/install-features/202311.0/install-the-data-exchange-api.md Outdated Show resolved Hide resolved
.../all/data-exchange/202311.0/tutorials-and-howtos/how-to-send-request-in-data-exchange-api.md Show resolved Hide resolved
gechetspr
gechetspr reviewed Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@gechetspr gechetspr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small changes required

.../all/data-exchange/202311.0/tutorials-and-howtos/how-to-send-request-in-data-exchange-api.md Outdated Show resolved Hide resolved
.../all/data-exchange/202311.0/tutorials-and-howtos/how-to-send-request-in-data-exchange-api.md Outdated Show resolved Hide resolved
gechetspr
gechetspr previously approved these changes Dec 28, 2023
View reviewed changes
@lenadoc lenadoc added in TW review PR is in review by a technical writer and removed in tech review PR is in review by a developer labels Jan 11, 2024
@lenadoc lenadoc self-assigned this Jan 11, 2024
@lenadoc lenadoc merged commit 9d6e42a into master Jan 11, 2024
13 checks passed
@lenadoc lenadoc deleted the feature/frw-6331/master-de-api-complex-endpoints-get-request branch January 11, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmarovydlo asmarovydlo asmarovydlo left review comments

@gechetspr gechetspr gechetspr left review comments

@andriitserkovnyi andriitserkovnyi Awaiting requested review from andriitserkovnyi

@lenadoc lenadoc Awaiting requested review from lenadoc

Assignees

@lenadoc lenadoc

Labels
in TW review PR is in review by a technical writer updated PR contains meaningful changes to some document
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimitriyTsemma @asmarovydlo @gechetspr @lenadoc