Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP-383: adjusted PBCs docs #2427

Merged
merged 28 commits into from
Jan 26, 2024
Merged

Conversation

oleksander-kiiashko
Copy link
Contributor

mharacewiat
mharacewiat previously approved these changes Jan 11, 2024
evgeniy-it
evgeniy-it previously approved these changes Jan 19, 2024
...
```

Main process not only combines and operates sub-processes, its main goal to build everything around the only reserved=”true” state named invoiced;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this part "its main goal to build everything around the only reserved=”true” state named invoiced;". Please explain what is meant here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That definitely makes no sense for the customers, replacing with the same one we have in Stripe documentation.

console data:import glossary
```

### Template changes in `CheckoutPage`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this whole step optional? Does it apply only in case if you have rewritten @CheckoutPage/views/payment/payment.twig?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, adding optional prefix.

…-enablement-docs

# Conflicts:
#	docs/pbc/all/payment-service-provider/202311.0/base-shop/third-party-integrations/payone/integration-in-the-back-office/integrate-payone.md
#	docs/pbc/all/usercentrics/integrate-usercentrics.md
stereomon
stereomon previously approved these changes Jan 26, 2024
Copy link
Contributor

@stereomon stereomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: René Klatt <rene.klatt@spryker.com>
evgeniy-it
evgeniy-it previously approved these changes Jan 26, 2024
Copy link
Contributor

@evgeniy-it evgeniy-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenadoc lenadoc added the new PR contains a new document label Jan 26, 2024
@lenadoc lenadoc merged commit 7215ed0 into master Jan 26, 2024
5 checks passed
@lenadoc lenadoc deleted the feature/acp-383/mb2-enablement-docs branch January 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new PR contains a new document
Development

Successfully merging this pull request may close these issues.

6 participants