Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cockroach to Command's list of engines #774

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

theory
Copy link
Collaborator

@theory theory commented Jul 29, 2023

The list recognizes engine names on the command-line. Add a test to ensure new engines added in the future won't be omitted. Thanks to @NOBLES5E for the spot!

@theory theory requested a review from autarch July 29, 2023 20:16
@theory theory self-assigned this Jul 29, 2023
@theory theory mentioned this pull request Jul 29, 2023
@theory theory changed the base branch from develop to rm-smartmatch July 29, 2023 20:33
autarch
autarch previously approved these changes Jul 29, 2023
Copy link
Contributor

@autarch autarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one small typo.

t/command.t Outdated Show resolved Hide resolved
The list recognizes engine names on the command-line. Add a test to
ensure new engines added in the future won't be omitted. Thanks to
@NOBLES5E for the spot!
Base automatically changed from rm-smartmatch to develop July 30, 2023 22:26
@theory theory dismissed autarch’s stale review July 30, 2023 22:26

The base branch was changed.

@theory theory merged commit 73071a9 into develop Jul 30, 2023
84 checks passed
@theory theory deleted the fix-engines-list branch July 30, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants