feat(sql/catalog): Support ALTER TABLE IF EXISTS (#2542)

* feat(sql/catalog): ALTER TABLE IF EXISTS
* Remove debug statements
* Remove print statement

internal/endtoend/testdata/ddl_alter_table_if_exists/postgresql/pgx/v4/query.sql

@@ -0,0 +1,2 @@
+-- name: Placeholder :exec
+SELECT 1;

internal/endtoend/testdata/ddl_alter_table_if_exists/postgresql/pgx/v4/schema.sql

@@ -0,0 +1,7 @@
+ALTER TABLE IF EXISTS foo ADD COLUMN bar integer;
+ALTER TABLE IF EXISTS bar RENAME COLUMN bar TO baz;
+ALTER TABLE IF EXISTS bat RENAME CONSTRAINT bar TO baz;
+ALTER TABLE IF EXISTS baz RENAME TO bar;
+ALTER TABLE IF EXISTS goo SET SCHEMA bar;
+ALTER TABLE IF EXISTS gob ATTACH PARTITION partition_name DEFAULT;
+ALTER TABLE IF EXISTS doo DETACH PARTITION partition_name;

internal/endtoend/testdata/ddl_alter_table_if_exists/postgresql/pgx/v4/sqlc.json

@@ -0,0 +1,13 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "engine": "postgresql",
+      "sql_package": "pgx/v4",
+      "name": "querytest",
+      "schema": "schema.sql",
+      "queries": "query.sql"
+    }
+  ]
+}

internal/endtoend/testdata/ddl_alter_table_if_exists/postgresql/pgx/v5/query.sql

@@ -0,0 +1,2 @@
+-- name: Placeholder :exec
+SELECT 1;

internal/endtoend/testdata/ddl_alter_table_if_exists/postgresql/pgx/v5/schema.sql

@@ -0,0 +1,7 @@
+ALTER TABLE IF EXISTS foo ADD COLUMN bar integer;
+ALTER TABLE IF EXISTS bar RENAME COLUMN bar TO baz;
+ALTER TABLE IF EXISTS bat RENAME CONSTRAINT bar TO baz;
+ALTER TABLE IF EXISTS baz RENAME TO bar;
+ALTER TABLE IF EXISTS goo SET SCHEMA bar;
+ALTER TABLE IF EXISTS gob ATTACH PARTITION partition_name DEFAULT;
+ALTER TABLE IF EXISTS doo DETACH PARTITION partition_name;

internal/endtoend/testdata/ddl_alter_table_if_exists/postgresql/pgx/v5/sqlc.json

@@ -0,0 +1,13 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "engine": "postgresql",
+      "sql_package": "pgx/v5",
+      "name": "querytest",
+      "schema": "schema.sql",
+      "queries": "query.sql"
+    }
+  ]
+}

internal/endtoend/testdata/ddl_alter_table_if_exists/postgresql/stdlib/query.sql

@@ -0,0 +1,2 @@
+-- name: Placeholder :exec
+SELECT 1;

internal/endtoend/testdata/ddl_alter_table_if_exists/postgresql/stdlib/schema.sql

@@ -0,0 +1,7 @@
+ALTER TABLE IF EXISTS foo ADD COLUMN bar integer;
+ALTER TABLE IF EXISTS bar RENAME COLUMN bar TO baz;
+ALTER TABLE IF EXISTS bat RENAME CONSTRAINT bar TO baz;
+ALTER TABLE IF EXISTS baz RENAME TO bar;
+ALTER TABLE IF EXISTS goo SET SCHEMA bar;
+ALTER TABLE IF EXISTS gob ATTACH PARTITION partition_name DEFAULT;
+ALTER TABLE IF EXISTS doo DETACH PARTITION partition_name;

internal/endtoend/testdata/ddl_alter_table_if_exists/postgresql/stdlib/sqlc.json

@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "engine": "postgresql",
+      "name": "querytest",
+      "schema": "schema.sql",
+      "queries": "query.sql"
+    }
+  ]
+}

internal/engine/postgresql/parse.go

@@ -241,6 +241,7 @@ func translate(node *nodes.Node) (ast.Node, error) {
 			return &ast.AlterTableSetSchemaStmt{
 				Table:     rel.TableName(),
 				NewSchema: makeString(n.Newschema),
+				MissingOk: n.MissingOk,
 			}, nil
 
 		case nodes.ObjectType_OBJECT_TYPE:
@@ -259,8 +260,9 @@ func translate(node *nodes.Node) (ast.Node, error) {
 		n := inner.AlterTableStmt
 		rel := parseRelationFromRangeVar(n.Relation)
 		at := &ast.AlterTableStmt{
-			Table: rel.TableName(),
-			Cmds:  &ast.List{},
+			Table:     rel.TableName(),
+			Cmds:      &ast.List{},
+			MissingOk: n.MissingOk,
 		}
 		for _, cmd := range n.Cmds {
 			switch cmdOneOf := cmd.Node.(type) {
@@ -600,16 +602,18 @@ func translate(node *nodes.Node) (ast.Node, error) {
 		case nodes.ObjectType_OBJECT_COLUMN:
 			rel := parseRelationFromRangeVar(n.Relation)
 			return &ast.RenameColumnStmt{
-				Table:   rel.TableName(),
-				Col:     &ast.ColumnRef{Name: n.Subname},
-				NewName: makeString(n.Newname),
+				Table:     rel.TableName(),
+				Col:       &ast.ColumnRef{Name: n.Subname},
+				NewName:   makeString(n.Newname),
+				MissingOk: n.MissingOk,
 			}, nil
 
 		case nodes.ObjectType_OBJECT_TABLE:
 			rel := parseRelationFromRangeVar(n.Relation)
 			return &ast.RenameTableStmt{
-				Table:   rel.TableName(),
-				NewName: makeString(n.Newname),
+				Table:     rel.TableName(),
+				NewName:   makeString(n.Newname),
+				MissingOk: n.MissingOk,
 			}, nil
 
 		case nodes.ObjectType_OBJECT_TYPE:

internal/sql/ast/alter_table_set_schema_stmt.go

@@ -3,6 +3,7 @@ package ast
 type AlterTableSetSchemaStmt struct {
 	Table     *TableName
 	NewSchema *string
+	MissingOk bool
 }
 
 func (n *AlterTableSetSchemaStmt) Pos() int {

internal/sql/ast/rename_column_stmt.go

@@ -1,9 +1,10 @@
 package ast
 
 type RenameColumnStmt struct {
-	Table   *TableName
-	Col     *ColumnRef
-	NewName *string
+	Table     *TableName
+	Col       *ColumnRef
+	NewName   *string
+	MissingOk bool
 }
 
 func (n *RenameColumnStmt) Pos() int {

internal/sql/ast/rename_table_stmt.go

@@ -1,8 +1,9 @@
 package ast
 
 type RenameTableStmt struct {
-	Table   *TableName
-	NewName *string
+	Table     *TableName
+	NewName   *string
+	MissingOk bool
 }
 
 func (n *RenameTableStmt) Pos() int {

internal/sql/catalog/table.go

@@ -18,6 +18,16 @@ type Table struct {
 	Comment string
 }
 
+func checkMissing(err error, missingOK bool) error {
+	var serr *sqlerr.Error
+	if errors.As(err, &serr) {
+		if serr.Err == sqlerr.NotFound && missingOK {
+			return nil
+		}
+	}
+	return err
+}
+
 func (table *Table) isExistColumn(cmd *ast.AlterTableCmd) (int, error) {
 	for i, c := range table.Columns {
 		if c.Name == *cmd.Name {
@@ -167,7 +177,7 @@ func (c *Catalog) alterTable(stmt *ast.AlterTableStmt) error {
 	}
 	_, table, err := c.getTable(stmt.Table)
 	if err != nil {
-		return err
+		return checkMissing(err, stmt.MissingOk)
 	}
 	for _, item := range stmt.Cmds.Items {
 		switch cmd := item.(type) {
@@ -206,11 +216,11 @@ func (c *Catalog) alterTableSetSchema(stmt *ast.AlterTableSetSchemaStmt) error {
 	}
 	oldSchema, err := c.getSchema(ns)
 	if err != nil {
-		return err
+		return checkMissing(err, stmt.MissingOk)
 	}
 	tbl, idx, err := oldSchema.getTable(stmt.Table)
 	if err != nil {
-		return err
+		return checkMissing(err, stmt.MissingOk)
 	}
 	tbl.Rel.Schema = *stmt.NewSchema
 	newSchema, err := c.getSchema(*stmt.NewSchema)
@@ -354,7 +364,7 @@ func (c *Catalog) dropTable(stmt *ast.DropTableStmt) error {
 func (c *Catalog) renameColumn(stmt *ast.RenameColumnStmt) error {
 	_, tbl, err := c.getTable(stmt.Table)
 	if err != nil {
-		return err
+		return checkMissing(err, stmt.MissingOk)
 	}
 	idx := -1
 	for i := range tbl.Columns {
@@ -375,7 +385,7 @@ func (c *Catalog) renameColumn(stmt *ast.RenameColumnStmt) error {
 func (c *Catalog) renameTable(stmt *ast.RenameTableStmt) error {
 	sch, tbl, err := c.getTable(stmt.Table)
 	if err != nil {
-		return err
+		return checkMissing(err, stmt.MissingOk)
 	}
 	if _, _, err := sch.getTable(&ast.TableName{Name: *stmt.NewName}); err == nil {
 		return sqlerr.RelationExists(*stmt.NewName)