ORDER BY does not enforce column to exist

[theFong]

Version

1.11.0

What happened?

When creating a query that orders by a non-existent column, sqlc does not emit a query.sql:x:y: column "adfadsf" does not exist error.

Relevant log output

No response

Database schema

-- Example queries for sqlc
CREATE TABLE authors (
  id   BIGSERIAL PRIMARY KEY,
  name text      NOT NULL,
  bio  text
);

SQL queries

-- name: ListAuthors :many
SELECT * FROM authors
ORDER BY adfadsf;

Configuration

version: 1
packages:
  - path: "sqlc"
    name: "sqlc"
    engine: "mysql"
    schema: "schema.sql"
    queries: "query.sql"

Playground URL

https://play.sqlc.dev/p/9b40e9e704f08dc389049f02786f9d072d0c51839a432ff196dadcdfa6b19900

What operating system are you using?

macOS

What database engines are you using?

MySQL

What type of code are you generating?

Go

[kimtore]

It would be great if sqlc could enforce validity of ORDER BY columns. We just had a regression because of dropped columns that were not removed from queries, and it passed straight through generation.

FWIW, we use Postgres.

[akutschera]

You are right. While there was code for checking "GROUP BY" clauses, the "ORDER BY" checks were missing. The commit above should fix that.