Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pingcap parser (for MySQL) #1759

Closed
akutschera opened this issue Jul 25, 2022 · 0 comments
Closed

Upgrade pingcap parser (for MySQL) #1759

akutschera opened this issue Jul 25, 2022 · 0 comments
Labels
enhancement New feature or request triage New issues that hasn't been reviewed

Comments

@akutschera
Copy link
Contributor

What do you want to change?

The pingcap parser used to parse MySQL statements has moved to a new github repository (see README

Upgrading it would require a new import statement for the dolphin engine.
It would also solve #1197 and #1754 (at least the parse errors will be gone).

What database engines need to be changed?

MySQL

What programming language backends need to be changed?

Go
@akutschera akutschera added enhancement New feature or request triage New issues that hasn't been reviewed labels Jul 25, 2022
@akutschera akutschera mentioned this issue Jul 25, 2022
Merged
kyleconroy pushed a commit that referenced this issue Jul 27, 2022
@akutschera
Upgrade pingcap parser (#1759) (#1760)
e5ba388 
* (chore): Upgrade tidb_parser to new repository

fixes: #1795
Refs: #1197 #1754

* test(MySQL): Add test for default column values

Refs: #1197 #1754
@kyleconroy kyleconroy mentioned this issue Jul 27, 2022
Merged
jlisthood pushed a commit to jlisthood/sqlc that referenced this issue Apr 28, 2023
@akutschera @jlisthood
Upgrade pingcap parser (sqlc-dev#1759) (sqlc-dev#1760)
ec7e36b 
* (chore): Upgrade tidb_parser to new repository

fixes: sqlc-dev#1795
Refs: sqlc-dev#1197 sqlc-dev#1754

* test(MySQL): Add test for default column values

Refs: sqlc-dev#1197 sqlc-dev#1754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage New issues that hasn't been reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyleconroy @akutschera