Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CALL statements in MySQL #2612

Closed
andrewmbenton opened this issue Aug 14, 2023 · 2 comments · Fixed by #2614
Closed

Add support for CALL statements in MySQL #2612

andrewmbenton opened this issue Aug 14, 2023 · 2 comments · Fixed by #2614
Labels
enhancement New feature or request triage New issues that hasn't been reviewed

Comments

@andrewmbenton
Copy link
Collaborator

andrewmbenton commented Aug 14, 2023 •
edited
Loading

What do you want to change?

Calling stored procedures is currently impossible with the MySQL engine. Here's a playground link:

https://play.sqlc.dev/p/f89f9de548fed5f1a23e3372932d252e0d3d525b8a4556ea008519dc32bb8879

Original Discord thread: https://discord.com/channels/946447283321438248/1139700396395352147

What database engines need to be changed?

MySQL
@andrewmbenton andrewmbenton added enhancement New feature or request triage New issues that hasn't been reviewed labels Aug 14, 2023
@orisano
Copy link
Contributor

orisano commented Aug 14, 2023

SQLite does not have a call statement

orisano added a commit to orisano/sqlc that referenced this issue Aug 14, 2023
@orisano
feat(engine/dolphin): support CALL statement
ea5d2b8 
for sqlc-dev#2612
@orisano orisano mentioned this issue Aug 14, 2023
Merged
@andrewmbenton andrewmbenton changed the title Add support for CALL statements in MySQL and SQlite Add support for CALL statements in MySQL Aug 14, 2023
@andrewmbenton
Copy link
Collaborator Author

SQLite does not have a call statement

Thanks, I should have checked. I've updated the issue title and description.

orisano added a commit to orisano/sqlc that referenced this issue Aug 28, 2023
@orisano
feat(engine/dolphin): support CALL statement
605b77a 
for sqlc-dev#2612
kyleconroy pushed a commit that referenced this issue Aug 29, 2023
@orisano
feat(engine/dolphin): support CALL statement (#2614)
e73ad79 
* feat(engine/dolphin): support CALL statement

for #2612

* chore: update tidb/parser for create procedure

* fix: rename type

* feat: support CREATE PROCEDURE

* test: add endtoend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage New issues that hasn't been reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(engine/dolphin): support CALL statement orisano/sqlc
2 participants
@andrewmbenton @orisano