Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More useful error messages for RPC failures #2881

Closed
andrewmbenton opened this issue Oct 18, 2023 · 0 comments · Fixed by #2885
Closed

More useful error messages for RPC failures #2881

andrewmbenton opened this issue Oct 18, 2023 · 0 comments · Fixed by #2885
Labels
enhancement New feature or request
Milestone
1.23.0

Comments

@andrewmbenton
Copy link
Collaborator

What do you want to change?

For instance, an authentication failure should explain common causes and solutions.

What database engines need to be changed?

No response

What programming language backends need to be changed?

No response
@andrewmbenton andrewmbenton added enhancement New feature or request triage New issues that hasn't been reviewed labels Oct 18, 2023
@kyleconroy kyleconroy removed the triage New issues that hasn't been reviewed label Oct 18, 2023
@kyleconroy kyleconroy added this to the 1.23.0 milestone Oct 18, 2023
andrewmbenton added a commit that referenced this issue Oct 19, 2023
@andrewmbenton
feat: Improve messaging for common cloud config and rpc errors
8750e0d 
1. Add a UnaryClientInterceptor for all gRPC client connections to
catch and rewrite unauthenticated error messages

2. Put the sqlc auth token in the config struct, and add simple validation

3. Add more explanatory error messages in cases where users try to use
cloud features without the proper configuration

4. Prevent sending the SQLC_AUTH_TOKEN env var to plugins

Resolves #2881

Resolves #2881
@andrewmbenton andrewmbenton mentioned this issue Oct 19, 2023
Merged
kyleconroy pushed a commit that referenced this issue Oct 19, 2023
@andrewmbenton
feat: Improve messaging for common cloud config and rpc errors (#2885)
4f875c1 
* feat: Improve messaging for common cloud config and rpc errors

1. Add a UnaryClientInterceptor for all gRPC client connections to
catch and rewrite unauthenticated error messages

2. Put the sqlc auth token in the config struct, and add simple validation

3. Add more explanatory error messages in cases where users try to use
cloud features without the proper configuration

4. Prevent sending the SQLC_AUTH_TOKEN env var to plugins

Resolves #2881

* Don't continue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.23.0
Development

Successfully merging a pull request may close this issue.

feat: Improve messaging for common cloud config and rpc errors sqlc-dev/sqlc
2 participants
@kyleconroy @andrewmbenton