Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MYSQL_USER and MYSQL_PASSWORD from docker-compose.yaml #1123

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Remove MYSQL_USER and MYSQL_PASSWORD from docker-compose.yaml #1123

merged 2 commits into from
Aug 16, 2021

Conversation

robsonpeixoto
Copy link
Contributor

The right way to configure the root password is using the environment variable
MYSQL_ROOT_PASSWORD.

It also remove the MYSQL_PASSWORD because is only used the root user.

From MySQL log:

2021-08-13 20:28:55+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql'
2021-08-13 20:28:55+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 8.0.26-1debian10 started.
2021-08-13 20:28:55+00:00 [ERROR] [Entrypoint]: MYSQL_USER="root", MYSQL_USER and MYSQL_PASSWORD are for configuring a regular user and cannot be used for the root user
    Remove MYSQL_USER="root" and use one of the following to control the root user password:
    - MYSQL_ROOT_PASSWORD
    - MYSQL_ALLOW_EMPTY_PASSWORD
    - MYSQL_RANDOM_ROOT_PASSWORD

robsonpeixoto and others added 2 commits August 13, 2021 17:34
The right way to configure the *root* password is using the environment variable
`MYSQL_ROOT_PASSWORD`.

It also remove the `MYSQL_PASSWORD` because is only used the root user.

From MySQL log:
```
2021-08-13 20:28:55+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql'
2021-08-13 20:28:55+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 8.0.26-1debian10 started.
2021-08-13 20:28:55+00:00 [ERROR] [Entrypoint]: MYSQL_USER="root", MYSQL_USER and MYSQL_PASSWORD are for configuring a regular user and cannot be used for the root user
    Remove MYSQL_USER="root" and use one of the following to control the root user password:
    - MYSQL_ROOT_PASSWORD
    - MYSQL_ALLOW_EMPTY_PASSWORD
    - MYSQL_RANDOM_ROOT_PASSWORD
```
@kyleconroy kyleconroy merged commit 481f892 into sqlc-dev:main Aug 16, 2021
@robsonpeixoto robsonpeixoto deleted the fix/docker-compose-mysql branch August 16, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants