Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(postgres): Add support for sql.NullInt16 #1376

Merged
merged 4 commits into from
Jan 14, 2022
Merged

feat(postgres): Add support for sql.NullInt16 #1376

merged 4 commits into from
Jan 14, 2022

Conversation

egtann
Copy link
Contributor

@egtann egtann commented Jan 14, 2022 •
edited
Loading

Go added support for sql.NullInt16 in the standard library as of go1.17 (golang/go#40082), so sqlc can now use the appropriate nullable type for int16.

kyleconroy
kyleconroy approved these changes Jan 14, 2022
View reviewed changes
Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree! Go 1.17 has been out long enough that I'm comfortable updating the target to require it. Once Go 1.18 lands, we'll need to figure out a strategy to support targeting different Go versions.

@kyleconroy kyleconroy merged commit 3edeba8 into sqlc-dev:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egtann @kyleconroy