Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgresql): Remove extra comment newline #1395

Merged
merged 2 commits into from
Jan 26, 2022
Merged

fix(postgresql): Remove extra comment newline #1395

merged 2 commits into from
Jan 26, 2022

Conversation

kyleconroy
Copy link
Collaborator

Fixes #1393

@kyleconroy kyleconroy merged commit d4d48ea into main Jan 26, 2022
@kyleconroy kyleconroy deleted the kyle/extra-new-line-comment-pgx branch January 26, 2022 04:10
@kevinburke
Copy link

whitespace, it'll cost ya

rliebz added a commit to rliebz/sqlc that referenced this pull request Feb 7, 2022
@rliebz
fix(postgresql): Remove extra newline with db argument
a3213d1 
The original fix (sqlc-dev#1395) for sqlc-dev#1393 did not cover the case where
`emit_methods_with_db_argument` was set to `true`. This follows the same
pattern to handle that case as well.
@rliebz rliebz mentioned this pull request Feb 7, 2022
Merged
kyleconroy pushed a commit that referenced this pull request Feb 8, 2022
@rliebz
fix(postgresql): Remove extra newline with db argument (#1417)
5ec0caa 
The original fix (#1395) for #1393 did not cover the case where
`emit_methods_with_db_argument` was set to `true`. This follows the same
pattern to handle that case as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL comments have one too many newlines for GoDocs
2 participants
@kyleconroy @kevinburke