feat: add support for Postgres multi dimensional arrays in Go #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pg-multi-dim-arrays
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
6 tasks
kyleconroy
previously requested changes
Sep 1, 2022
There was a problem hiding this comment.
This looks like a solid improvement over our current multi-dimension support. The code generation looks correct, but I do want to verify that this works against a running PostgreSQL instance before merging.
Can you fix the merge conflicts? Happy to merge after that.
…e/pg-multi-dim-arrays
Thanks for taking a look. Could you clarify the ask here? Is there an aspect of this that should change for the lib/pq package? |
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
|
@kyleconroy soft ping for another review when you have a chance. |
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
…e/pg-multi-dim-arrays
This was referenced Jun 7, 2023
kyleconroy
pushed a commit
that referenced
this pull request
Jul 30, 2023
…#2338) This PR adds support for generating model fields from multi-dimensional postgresql array columns. The approach here is to pass around an additional column attribute array_bounds representing the dimensions of the postgres array column. When generating code, the array_bounds is checked along is_array to determine the dimensions of the resulting struct field. Would be happy to hear alternative approaches or solutions here as well. https://www.postgresql.org/docs/14/arrays.html Fixes issue: #1494 Replaces #1651 #2308 #2309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for generating model fields from multi-dimensional postgresql array columns. The approach here is to pass around an additional column attribute
array_boundsrepresenting the dimensions of the postgres array column. When generating code, thearray_boundsis checked alongis_arrayto determine the dimensions of the resulting struct field. Would be happy to hear alternative approaches or solutions here as well. More info: Postgres Arraysfixes issue: #1494