fix: 🐛 Correctly switch coalesce() result .NotNull value
#1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change follows the previous implementation that mutates and returns the first column, but switches only the `.NotNull` value depending on the situation. BREAKING CHANGE: 🧨 `coalesce()` may assign nullable results ✅ Closes: sqlc-dev#1663
mpyw
commented
Jun 7, 2022
Comment on lines
+171
to
+175
| if firstColumn != nil { | ||
| firstColumn.NotNull = shouldNotBeNull | ||
| firstColumn.skipTableRequiredCheck = true | ||
| cols = append(cols, firstColumn) | ||
| } else { |
There was a problem hiding this comment.
Question: Is this really correct that using first column on this way?
Comment on lines
+154
to
157
| if _, ok := arg.(*ast.A_Const); ok { | ||
| shouldNotBeNull = true | ||
| continue | ||
| } |
There was a problem hiding this comment.
Question: Is it sufficient that asserting only A_Const and ColumnRef?
Comment on lines
+164
to
+167
| if firstColumn == nil { | ||
| firstColumn = c | ||
| } | ||
| shouldNotBeNull = shouldNotBeNull || c.NotNull |
There was a problem hiding this comment.
Question: What are the differences between n.Args.Items and their inner columns?
kyleconroy
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows the previous implementation that mutates and returns the first column, but switches only the
.NotNullvalue depending on the situation.A_Constnode may containNull.Also, I am new to Golang OSS, so I may be making some large mistakes. Thank you in advance for your review.
BREAKING CHANGE: 🧨
coalesce()may assign nullable results✅ Closes: #1663