Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codgen: Include serialized codegen options #1890

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

kyleconroy
Copy link
Collaborator

These options were already included, but not in a way that made them easy to use. We could also pass in a pointer to the existing setting document, but I think this is cleaner

These options were already included, but not in a way that made them
easy to use. We could also pass in a pointer to the existing setting
document, but I think this is cleaner
@kyleconroy kyleconroy marked this pull request as draft October 11, 2022 16:08
@kyleconroy kyleconroy marked this pull request as ready for review October 12, 2022 04:02
@kyleconroy kyleconroy merged commit cf74be9 into main Oct 12, 2022
@kyleconroy kyleconroy deleted the kyle/codegen-request-plugin-options branch October 12, 2022 04:03
akutschera pushed a commit to akutschera/sqlc that referenced this pull request Nov 10, 2022
* codgen: Include serialized codegen options

These options were already included, but not in a way that made them
easy to use. We could also pass in a pointer to the existing setting
document, but I think this is cleaner

* Fix tests

* Fix tests (again)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant