feat: improve support for sqlite named parameters #2259
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlite supports the named parameter, but currently sqlc does not rewrite it as it does in postgresql.
Because named.IsParamSign judges whether named parameter is named or not by the content of ast.A_Expr, but sqlite3 converts from BindContext to ast.ParamRef and loses the name information.
In sqlite3, it is modified to return ast.A_Expr or ast.ParamRef depending on the contents of BindContext when converting.
And, parameter functions do not work in sqlite.
This is because names containing a dot, such as
sqlc.arg
, cause a syntax error.So functions starting with
sqlc_
are interpreted as starting withsqlc.
in sqlite.related: