fix(ci): bump go version for govulncheck in ci.yml #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmbenton
force-pushed
the
andrew/patch-1
branch
from
e2f5b79
to
770aa30
Compare
andrewmbenton
force-pushed
the
andrew/patch-1
branch
from
770aa30
to
680805f
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this technically "fixes" the issue of our govulncheck CI check failing, but brings up a question: should we really be soft-blocking a merge when this CI check fails? And if not, what's the point of running this check in CI, and should we just run it somewhere else.