Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Fix to not scan children under ast.RangeSubselect when retrieving table listing #2573

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Aug 3, 2023

close #2569
close #1722

astutils.Search does not stop traversing in the middle, so it returns redundant table nodes under ast.RangeSubselect.
I solved this problem by adding a visitor to ast.RangeSubselect that does not traverse the child nodes of ast.RangeSubselect.

@kyleconroy kyleconroy merged commit fb9e375 into sqlc-dev:main Aug 28, 2023
7 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants