fix Go struct tag parsing #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
304ba5d didn't correctly handle struct tags whose value contained a space. (My fault.) Use a proper struct tag library with a dedicated parser that handles all the edge cases. Less code, and better.
josharian
force-pushed
the
josh/go-struct-tag-parsing
branch
from
ae83ce7
to
18f3d48
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
304ba5d didn't correctly handle struct tags whose
value contained a space. (My fault.)
Use a proper struct tag library with a dedicated parser
that handles all the edge cases. Less code, and better.