Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(astutils): remove redundant nil check in Walk #2660

Merged
merged 1 commit into from
Aug 28, 2023
Merged

refactor(astutils): remove redundant nil check in Walk #2660

merged 1 commit into from
Aug 28, 2023

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Aug 26, 2023

From the Go docs:

"For a nil slice, the number of iterations is 0." https://go.dev/ref/spec#For_range

Therefore, an additional nil check for before the loop is unnecessary. Example: https://go.dev/play/p/tMQ9JcUOMcI

From the Go docs:

  "For a nil slice, the number of iterations is 0." [1]

Therefore, an additional nil check for before the loop is unnecessary.

[1]: https://go.dev/ref/spec#For_range

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@kyleconroy kyleconroy merged commit ecf4980 into sqlc-dev:main Aug 28, 2023
8 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants