Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codegen): use correct Go types for bit strings and cid/oid/tid/xid with pgx/v4 #2668

Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix(codegen): use correct Go types for bit strings and cid/oid/tid/xid with pgx/v4 #2668

merged 1 commit into from
Aug 30, 2023

Conversation

andrewmbenton
Copy link
Collaborator

resolves #2667

kyleconroy
kyleconroy approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests would have caught the issue, as the code wouldn't compile.

@kyleconroy kyleconroy added this to the 1.21.0 milestone Aug 28, 2023
@kyleconroy kyleconroy merged commit faa1c9d into main Aug 30, 2023
8 checks passed
@kyleconroy kyleconroy deleted the andrew/fix-pgx-v4-types branch August 30, 2023 15:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

sqlc doesn't handle oid types correctly with pgx/v4
2 participants
@andrewmbenton @kyleconroy