fix(engine/dolphin): support enum in ALTER definition #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
approved these changes
Oct 13, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got in a case similar to #1503. This PR will fix #1503.
I found one discrepancy between column definition between create table and alter definition. I fix it by defining a common sub function.
On generic engine update part, it was missing to create enum on alter table statement compared to create. I added an argument to the func
createEnumto override previous definition when needed.I added two tests to cover the two ALTER case MODIFY and CHANGE.
I only know very few part of the codebase so let me know If I need to change anything to make this merged.