Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codegen/golang): support name type #2715

Merged
merged 1 commit into from
Sep 9, 2023
Merged

fix(codegen/golang): support name type #2715

merged 1 commit into from
Sep 9, 2023

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Sep 8, 2023

close #2714

@andrewmbenton
Copy link
Collaborator

andrewmbenton commented Sep 8, 2023 •
edited
Loading

This seems safe to merge, but I'm having a hard time determining where this name type is defined, and whether we need to add support for more types defined in similar places?

@orisano
Copy link
Contributor Author

orisano commented Sep 9, 2023

https://www.postgresql.org/docs/current/datatype-character.html#DATATYPE-CHARACTER-SPECIAL-TABLE

@andrewmbenton
Copy link
Collaborator

Good find, thanks.

@andrewmbenton andrewmbenton merged commit 79c58b7 into sqlc-dev:main Sep 9, 2023
6 of 8 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pg_catalog.pg_tables uses interface{} rather than string types
2 participants
@orisano @andrewmbenton