Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine/sqlite): fix grammer to avoid missing join_constraint #2732

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix(engine/sqlite): fix grammer to avoid missing join_constraint #2732

merged 1 commit into from
Sep 14, 2023

Commits on Sep 14, 2023

  1. fix(engine/sqlite): fix grammer to avoid missing join_constraint 

    close sqlc-dev#2729

ANTLR's API has difficulty handling the case where there is no join_constraint
corresponding to join_operator in join_clause, so an empty join_constraint is accepted.

It is defined as such in the sqlite documentation.
https://www.sqlite.org/syntax/join-clause.html
https://www.sqlite.org/syntax/join-constraint.html
    @orisano
    orisano committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    d2c69f1 View commit details
    Browse the repository at this point in the history