refactor(codegen): remove golang and json settings from plugin proto #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to simplify the codegen plugin proto, I've removed the Go and JSON plugin settings and instead pass those settings encoded as JSON to their respective plugins.
andrewmbenton
commented
Oct 11, 2023
andrewmbenton
commented
Oct 11, 2023
Comment on lines
+111
to
+113
| enums := buildEnums(req, options) | ||
| structs := buildStructs(req, options) | ||
| queries, err := buildQueries(req, options, structs) |
There was a problem hiding this comment.
I think some of these funcs won't need to take the req as a param at all, once we figure out how to handle overrides and renames.
kyleconroy
reviewed
Oct 11, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify the codegen plugin proto, I've removed the Go and JSON plugin settings and instead pass those settings encoded as JSON to their respective plugins.
I introduce a new struct type,
optsin each codegen package, for deserialization of the passed settings. These are essentially the Go types formerly generated from the proto, but now isolated.