fix(config): Validate database config in all cases
#2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `continue` in `Validate` was preventing validation in cases where no Go codegen is configured. * Move some Go-specific config validation into codegen package * Update config validation test * Remove some dead code
andrewmbenton
commented
Oct 14, 2023
Comment on lines
-7
to
-10
| sqlGo := sql.Gen.Go | ||
| if sqlGo == nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
The offending continue. The Go-specific options validation below moved into codegen.
kyleconroy
approved these changes
Oct 15, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
continueinValidatewas preventing validation in cases where no Go codegen is configured.