Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Support functions with OUT params #2865

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix(compiler): Support functions with OUT params #2865

merged 3 commits into from
Oct 17, 2023

Conversation

kyleconroy
Copy link
Collaborator

@kyleconroy kyleconroy commented Oct 16, 2023 •
edited
Loading

Fixes #1654

Don't panic if a function doesn't have a return type. Load the out parameters if they exist.

@kyleconroy kyleconroy merged commit 1ac6f19 into main Oct 17, 2023
8 checks passed
@kyleconroy kyleconroy deleted the andrew/pg-func-out-panic branch October 17, 2023 17:01
@p-linnane p-linnane mentioned this pull request Oct 24, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewmbenton andrewmbenton andrewmbenton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlc crashes when calling a function with OUT arg
2 participants
@kyleconroy @andrewmbenton