Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Take the maximum array dimensions #3034

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

kyleconroy
Copy link
Collaborator

Fixes a bug introduced by #3032

The end-to-end tests on that PR didn't fail as the database-based backed analyzer only runs on PRs created in this repo, which is a bug we'll need to fix soon.

We need to keep reading the value from the column definition for a specific reason

The current implementation does not enforce the declared number of dimensions either. Arrays of a particular element type are all considered to be of the same type, regardless of size or number of dimensions. So, declaring the array size or number of dimensions in CREATE TABLE is simply documentation; it does not affect run-time behavior.

This means that arrays that should contain arrays of arrays of strings, could just contain an array of strings. We'll need to figure out how to handle this case in a future PR.

@kyleconroy kyleconroy merged commit caaaacc into main Dec 4, 2023
8 checks passed
@kyleconroy kyleconroy deleted the kyle/fix-array-dims branch December 4, 2023 22:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant