Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(push): Add tag support #3074

Merged
merged 1 commit into from
Dec 20, 2023
Merged

feat(push): Add tag support #3074

merged 1 commit into from
Dec 20, 2023

Conversation

kyleconroy
Copy link
Collaborator

When pushing queries to sqlc Cloud, you can now specify tags in the push command.

sqlc push --tag one --tag two

These tags operate similar to Docker and Git tags. They can be overwritten and will always point to a single push.

The verify command gets the new --against flag. If supplied, we'll use the tagged push to look up queries to verify against the current schema.

sqlc verify --against one

Also support passing a tag to verify
Comment on lines +13 to +15
// TODO: Move these to a command-specific struct
Tags []string
Against string
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gross, right now we expect the syntax of the Verify and Push command to be the same. Will clean this up in another pull request.

@kyleconroy kyleconroy merged commit e1309fb into main Dec 20, 2023
8 checks passed
@kyleconroy kyleconroy deleted the kyle/push-tags-verify-against branch December 20, 2023 23:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants