Avoid generating empty Go imports statement #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this will likely require updating some test output. |
|
@andrewmbenton — My bad. I was in a haste and forgot to run tests locally. I've removed |
|
@andrewmbenton — Just curious if this might be something you will consider merging, now that the tests all work? |
lisitsky
pushed a commit
to lisitsky/sqlc
that referenced
this pull request
Jun 21, 2024
* Avoid generating empty Go imports statement Maybe fixes sqlc-dev#3134 * Remove `import ()` from `testdata` golden files
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3134, hopefully.